Repository navigation
Issue panel: opened issues are tabs (0.1.17) - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The side panel showed one issue; clicking another on the list or board replaced it. Comparing two issues meant going back and forth.
What
Design:
design/README.md§ Issue panel tabs (v0.1.17).?issue=), so links, reload and back/forward work as before. The open tabs are the person's working set: kept insessionStorageper browser tab, never in the URL, at most 20 (least recently active evicted).J/Kwith the panel open replaces the active tab in place (no trail of tabs); walking onto an issue that already has a tab activates it instead. Browsing never closes a tab.Esc, Delete on the focused tab) activates the right neighbour, else the left; closing another tab leaves the active one alone; the panel's × closes all.web/src/model/panel-tabs.tswith table tests;usePanelTabsis shared by the issues pages and the inbox.Unchanged: the command palette and links inside an issue (parent, children, blockers) still go to the full page.
Verification
tsc --noEmit,bun test src(156 pass).Escon the last → panel closed,issueremoved; reload restores the tabs; fresh?issue=APT-9→ one tab; three tabs thenJ×4 → active changes, still three tabs; open A, B, Back → A active, both present; page scroll kept on tab switch; 12 tabs → strip scrolls, active tab in view; Home/Right/Delete on the strip; unknown issue shows not-found in a closable tab; inbox opens tabs. At 390px wide the strip scrolls and close buttons are 32px.