Repository navigation
Attachments: several files when creating an issue, 10 MiB per file (0.1.16) - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What
web/src/features/issues/pending-attachments.tsx); pure parts inweb/src/model/issues.ts.domain.AttachmentMaxBytesis the single server constant; migration 015 widens the column CHECK; the SPA constant and copy follow.Trade-off
Attachments are
bytearows. At 10 MiB each upload and download is held in memory once, and an issue can hold 100 MiB. Recorded indesign/README.md.Verification
go vet ./cmd/...;go test -count=1 ./cmd/...against a disposable Postgres 17, including the newTestAttachmentSizeBoundary(exactly 10 MiB stored, one byte more refused) and the migration count.web:tsc --noEmit,bun test src./reportstill adds and refuses files.