Repository navigation
web: template path never pairs with a marketplace definition - #5
Merged
Merged
Conversation
resolveCreateCatalog picked the first ApplicationStackDefinition with the template's component count. Marketplace apps are ApplicationStackDefinitions too (catalogSource set, AppCatalogSource-owned); on Craftsman the first two-component definition was builder-console, so creating a Next.js app would deploy the console image under the user's app name. Only platform-shipped definitions (no catalogSource) are candidates. Mirrors platform #6481.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveCreateCatalog picked the first ApplicationStackDefinition with the
template's component count. Marketplace apps are ApplicationStackDefinitions
too (catalogSource set, AppCatalogSource-owned); on Craftsman the first
two-component definition was builder-console, so creating a Next.js app would
deploy the console image under the user's app name. Only platform-shipped
definitions (no catalogSource) are candidates. Mirrors platform #6481.