Repository navigation
web: take the publish name from the reply, not the whole reply - #11
Merged
Merged
Conversation
During the prepare exchange the console stored the user's first reply as the app name whenever it was an offered chip or a short line. The AI's chips are sentences (「入退室・金庫管理にしたい」「ほかの名前にしたい」), so choosing one stored the sentence as publishPreferences.name and the draft title. The next reply then closed the exchange and the fixed ready line was backdated above it, as if the AI had moved on without an answer (APT-792). - Extract the name from choice wording; chips get the same checks as typed replies. - Replies that defer or ask for a suggestion keep the name and audience questions open instead of ending the exchange. - The ready line always sorts after every message already shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tracker APT-792. After the app is created the console asks for the publish name and audience. On Craftsman (
draft-a522e670) the user picked the AI's chip 「ほかの名前にしたい」 and the console stored that sentence aspublishPreferences.nameand the draft title. The next reply (「提案して」) closed the exchange, and the fixed line 「下地ができました。ここから画面を作ります。」 was inserted above it, directly under the AI's unanswered question.Cause
prepareAnswerstook the first reply verbatim as the name when it was an offered chip or any short line.messagesFromDraftstamped the ready line with the last answered turn's time.Change
Xにしたい,Xでよい,X is fine,Use X); chips, including follow-up chips, pass the same checks as typed replies.Not in this PR
Checks
bun test src/model/build src/features/build: 427 passbunx tsc --noEmit: clean