Repository navigation
web: request the plan for a draft without creationExecutions - #10
Merged
Merged
Conversation
The Platform API omits an empty creationExecutions array. generate() read its length unguarded, so every never-executed draft threw before the plan generation request and showed 計画を作れませんでした (APT-748, APT-749).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Craftsman (v0.5.3) every new AI draft shows 「計画を作れませんでした」 and retrying does not help.
generate()readscurrent.creationExecutions.length, but the Platform API omits an emptycreationExecutions(omitempty), so a never-executed draft throws a TypeError beforecreateGenerationis called. Introduced by #4.Change
creationExecutions); it fails without the fix.Evidence
Craftsman
pj-a167a047c8d3, read-only: 0 stored plan generations for the 8 drafts handed off since 2026-11-10; the 9 never-executed stored drafts all throw on this expression.Tracker: APT-748, APT-749
Checks
bun test src/features/build/use-build-session.test.tsx: 37 pass (new test fails on main)tsc --noEmit: clean