Repository navigation
Conversation
Collaborator
|
Does the in-flight counter go down now in Recovery? |
rpaulo
approved these changes
Oct 21, 2026
ACKs for packets sent on a path that has since been removed, such as the old path after a migration, were dropped before packetAcked ran. The in-flight count never went down, so the PTO timer was re-armed forever, and the packets' contents were never acknowledged. Retire them anyway, skipping only the steps that need the path.
kkuk24
force-pushed
the
kkuk/fix-ack-after-path-teardown
branch
from
October 28, 2026 20:25
085221a to
ca81093
Compare
Contributor
Author
Yes it goes down now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACKs for packets sent on a path that has since been removed, such as the old path after a migration, were dropped before packetAcked ran. The in-flight count never went down, so the PTO timer was re-armed forever, and the packets' contents were never acknowledged. Retire them anyway, skipping only the steps that need the path.