Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-existing, and not caused by this PR, but since this
setUpis being touched anyway: thesetMaxTsBlockLineNumber(2).setMaxNumberOfPointsInPage(5)call just below runs afterinitClusterEnvironment(). The node configuration is only written when the nodes are created, so these two settings never reach the running cluster, and the test has always run with the defaults. Moving them beforeinitClusterEnvironment()would apply them, but it changes the effective configuration (and possibly the memory numbers above), so it may be better as a separate change.