Repository navigation
HBASE-30348 Throttles should work for system tables (excluding quotas, meta, namespace) [branch-2] - #8785
Draft
rmdmattingly wants to merge 1 commit into
Draft
HBASE-30348 Throttles should work for system tables (excluding quotas, meta, namespace) [branch-2]#8785rmdmattingly wants to merge 1 commit into
rmdmattingly wants to merge 1 commit into
Conversation
…, meta, namespace) System tables outside the hbase namespace, such as the backup tables, can generate a lot of IO but could never be throttled. Only hbase:meta, hbase:quota and hbase:namespace remain exempt, because they are read while the master is still initializing. Throttling is now best effort: no request waits for the quota cache to load. Until a load fully succeeds, requests get default quota state, which does not throttle, and failed loads are retried. Waiting on the load inline is what deadlocked master startup on branch-2 in the first attempt at this change, since the load needs hbase:quota and the master. Each refresh also reloads once more when it finds tables with new quotas. Cluster scope table quotas are converted to machine scope using factors computed before the fetch, so a newly limited table previously got the full cluster limit on every RegionServer until the next refresh. Per-user table quotas now get factors as well; before, only tables with a table quota did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft backport of #8774 to branch-2. It's open mainly to run CI on branch-2, since the first attempt at HBASE-30348 (#8591) deadlocked in tests here and was reverted.
The cherry-pick applied cleanly apart from one test import,
HBaseTestingUtil→HBaseTestingUtility.🤖 Generated with Claude Code