[DaanHoogland]

Part of the split of #13884 (phase out the Config enum, #10752).

Description

This PR...

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[github-actions]

🔴 Test Coverage Grade: D — Marginal

Metric	Value
Line coverage	25.80%
Branch coverage	20.07%

Grade Scale

Grade	Line Coverage	Meaning
🟢 A	≥ 80%	Excellent - this code sleeps well at night 😴
🟡 B	60-79%	Good - almost there, don't stop now 😉
🟠 C	40-59%	Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D	20-39%	Marginal - boldly shipping where no test has gone before 🖖
⛔ F	< 20%	Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[DaanHoogland]

Duplicate of #14469; vpn-vpc does not depend on account.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.71%. Comparing base (c800b90) to head (2d2cd82).
⚠️ Report is 1 commits behind head on ghi10752-config-account.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java	0.00%	3 Missing ⚠️
...com/cloud/network/vpn/Site2SiteVpnManagerImpl.java	0.00%	2 Missing ⚠️
...va/com/cloud/network/ovs/OvsTunnelManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                      Coverage Diff                      @@
##             ghi10752-config-account   #14480      +/-   ##
=============================================================
+ Coverage                      20.69%   20.71%   +0.01%     
- Complexity                     21723    21738      +15     
=============================================================
  Files                           6508     6508              
  Lines                         591033   592110    +1077     
  Branches                       72448    72956     +508     
=============================================================
+ Hits                          122341   122631     +290     
- Misses                        455417   456194     +777     
- Partials                       13275    13285      +10     

Flag	Coverage Δ
uitests	3.88% <ø> (ø)
unittests	22.01% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud