Repository navigation
[CALCITE-6245] A ValidationError occurs when a named parameter is used on a ScalarFunction or AggregateFunction - #5340
Merged
Conversation
mihaibudiu
approved these changes
Oct 19, 2026
| * @param argName argument name to look up | ||
| * @return index of the first matching parameter, or -1 if not found | ||
| */ | ||
| public static int lookupParamName(List<String> paramNames, String argName) { |
Contributor
There was a problem hiding this comment.
I think caseInsensitive should be in the name of the function
Member
Author
There was a problem hiding this comment.
Done, renamed to lookupParamNameCaseInsensitive.
| /** Looks up a parameter name in a list of formal parameter names, | ||
| * case-insensitively. | ||
| * | ||
| * <p>Argument names from the parser are subject to unquoted casing (for |
Contributor
There was a problem hiding this comment.
this paragraph only confuses things
Member
Author
There was a problem hiding this comment.
Agreed, removed. The javadoc now only describes the behavior; with the new method name, the rationale paragraph was redundant.
…d on a ScalarFunction or AggregateFunction
xuzifu666
force-pushed
the
calcite-6245
branch
from
October 23, 2026 13:02
db77885 to
88e5066
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/CALCITE-6245