Repository navigation
Java SDK: Reject IDs that collide with task group join nodes - #74781
Draft
FrankYang0529 wants to merge 1 commit into
Draft
FrankYang0529 wants to merge 1 commit into
FrankYang0529 wants to merge 1 commit into
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
dag.taskGroup("transform").task("upstream_join_id", Clean.class). Airflow accepts the Dag, and the task dependencies in the Dag are right. But the Graph view shows the wrong edges. If a task runs upstream of the group, the edge from that task into the group disappears, andtransform.upstream_join_idgets an edge to itself.DuplicateTaskIdFoundfor the same Dag. The Go SDK also rejects that Dag.How
DagDef.addTaskandDagDef.addGroupreject an ID that is a join node ID of an existing group.DagDef.addGroupalso rejects a group when a task already has one of the group's join node IDs.Was generative AI tooling used to co-author this PR?