Repository navigation
Fix breeze down ignoring the --cleanup-build-cache flag - #73964
Open
Andrushika wants to merge 5 commits into
Open
Andrushika wants to merge 5 commits into
Andrushika wants to merge 5 commits into
Conversation
breeze down --cleanup-build-cache and breeze doctor removed a volume named airflow-cache-volume, but compose prefixes the volume with the project name, so neither ever removed anything. A plain breeze down removed the volume every time instead, although the docs say build caches are only deleted with an explicit cache-cleanup flag.
Andrushika
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
September 30, 2026 15:36
fat-catTW
reviewed
Oct 13, 2026
…urn-off-status # Conflicts: # dev/breeze/doc/images/output-commands.svg
1 task done
fat-catTW
reviewed
Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Breeze mounts a compose volume on
/root/.cacheof the airflow container. It holds the uv, pip and node caches. #48740 added it, together withbreeze down --cleanup-build-cacheand a step inbreeze doctorto remove it. The docs say thatdowndoes not delete build caches unless an explicit cache-cleanup flag is passed.The code does the opposite:
breeze doctorrundocker volume rm --force airflow-cache-volume. Docker Compose prefixes the volume with the project name, so the real volume is for examplebreeze_airflow-cache-volume. No volume has the bare name, and--forcehides the miss. Both lines are unchanged since Improve caching strategy for docker breeze runs #48740.breeze downremoves all volumes of the project, so it removes the cache every time.So on main
breeze downdeletes the cache, andbreeze down -p -bkeeps it.What
breeze downnow recognises the volume by itscom.docker.compose.volumelabel and keeps it unless--cleanup-build-cacheis passed. The flag also works together with--preserve-volumes.breeze doctorremoves the volume after its confirmation. The cache of a deleted worktree is still removed without the flag.This changes what a plain
breeze downremoves. Each project keeps about 100 MB after it, because the image already ships 98 MB in/root/.cache. Happy to keep only the flag fix if that is not wanted.related: #48740, #73836.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5.1) following the guidelines