Repository navigation
ELF: fix DWARF 5 source file lookups - #879
Conversation
|
CLE is enough of an end-to-end system that I would strongly prefer we test against real binaries rather than mocks. Can you either synthesize the subject of your testcase into an actual ELF or find an in-the-wild redistributable ELF and commit it to angr/binaries? |
|
hi, i've opened angr/binaries#276 with three synthetic ELF fixtures, assembly sources, and a rebuild script. They cover DWARF 4 and DWARF 5 filename indexing with relative and absolute directories, check on this pls |
|
Please update your test cases to use the real binaries before I can hit merge! |
|
updated |
|
can you rebase your branch, CI is mad about the devel version pins |
afda3ea to
8e9038f
Compare
|
done |
|
This does not seem to be correctly rebased. pyproject.toml still lists archinfo==10.0.7 on your branch, while cle master lists archinfo==10.0.8. We're working on making it so that this will be less stupid in the future, but in the meantime can you try again? |
8e9038f to
883cdf0
Compare
|
now should be good |
|
thanks for sticking with it 😵💫 🫡 |
Fix file and directory lookups in DWARF 5 line tables, which use zero-based indices. Preserve legacy indexing and the implicit compilation directory for older versions.
Added regression coverage for DWARF 4/5 and relative/absolute directories.
Closes #548