Repository navigation
Catch client exception - #101
Merged
Merged
Conversation
maxmmitchell
marked this pull request as ready for review
October 20, 2026 20:28
maxmmitchell
marked this pull request as draft
October 20, 2026 20:35
maxmmitchell
marked this pull request as ready for review
October 20, 2026 20:36
maxmmitchell
force-pushed
the
client-exception
branch
from
October 20, 2026 20:40
b8a37e5 to
dd9af71
Compare
cka-dev
approved these changes
Oct 21, 2026
cka-dev
left a comment
cka-dev
left a comment
Contributor
There was a problem hiding this comment.
lgtm, but I would recommend considering a differentiation of quota errors from other client errors (4xx) and tailoring the hint. For example for 429 would suggest checking quota/billing, and for 403 suggest checking the API key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClientExceptions can be thrown in a variety of scenarios, such as when the user is out of quota. Rather than crashing the CLI, we should catch and log these exceptions and print a helpful error message to the user.