Repository navigation
fix: flush queued logs without stopping the worker - #370
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
QueuedLogHandler.flush()currently stops its background worker. Records emitted afterward remain queued instead of being sent. This addresses the flush/stop behavior reported in #203.Make
flush()wait for outstanding sends, bounded byclose_wait, while leaving the worker available for subsequent records. Move worker shutdown toclose(). Queue entries are marked complete after sending (including error handling), so flushing also waits for a batch that the worker has already dequeued. During shutdown, check that the queue is empty before exiting after an empty batch.Add real-worker regression tests for repeated flushes, empty flushes, an in-flight send, the flush timeout, send failures, and close. The initial five tests failed before the change. The fix does not make a handler reusable after
close()or logging reconfiguration that closes it.Validation:
python -m pytest tests/unit tests/ci/build-test -q— 63 passed, 8 skipped on Python 3.12. Live SLS integration and legacy Python runtimes were not exercised locally.