Repository navigation
Conversation
main fails build_top now that TIMESCALEMOD is an error in the Verilator version used by CI: types.svh, zicsr/types.svh and ecall_processor.sv don't set a time unit, while the rest of the sources do. Added src/timescale.svh to those three.
Zosili
force-pushed
the
fix/verilator-timescalemod
branch
from
November 12, 2026 05:12
d591ab8 to
9bc234c
Compare
Zosili
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main fails
build_topsince the Verilator version in the CI image treatsTIMESCALEMODas an error:src/headers/types.svh,src/ext/zicsr/types.svhandsrc/priv/ecall_processor.svdon't set a time unit, while the rest of the sources do. Addingsrc/timescale.svhto those three fixes it.Checked with svlint and by compiling the three files in ModelSim; the Verilator run has to come from CI.