Repository navigation
DDIR: corgi pin to 708ca28 (range into gather, foldhash rows, faster byte sorts) - #1067
Open
frankmcsherry wants to merge 1 commit into
Open
frankmcsherry wants to merge 1 commit into
frankmcsherry wants to merge 1 commit into
Conversation
…byte sorts) Moves the corgi pin from 2751e04 to 708ca28, which brings three merged corgi changes: - WIP#130: a `range` read only by a `gather` runs as one span copy. - WIP#131: byte and word rows hash with an in-tree copy of foldhash. DDIR's hash-prefixed keys change once. - WIP#132: byte lists sort seven bytes a pass, with cheaper order checks. The lambda printer meets corgi's fused `GatherRange` in optimized graphs. It prints the `range` and `gather` the fusion stands for, spelled as before the fusion, so printed plans are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019XsakwFGwtESwZ1gSYwG4o
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves DDIR's corgi pin from
2751e04to708ca28, bringing in the three corgi PRs merged today:rangeread only by agatherruns as one span copy, without writing out positions. ClickBench 0.898×.One code change. The lambda printer has to spell corgi's new fused
GatherRangeop, which now appears in optimized graphs (for example in the top-20 reduces of IC2, IC5 and IC9). It prints therangeandgatherthe fusion stands for, spelled as they were before the fusion: a tuple read only by the fused node keeps its fields' spellings for it. Printed plans are unchanged, and the plan-pairs corpus passes without updates.Checks:
cargo test -p differential-dataflow -p differential-dogs3 -p interactive -p ddir-server(484 passed), the plan-pairs corpus, and the 1,000-case release difftest.--check-lambdasround-trips a lambda containing the fused op.🤖 Generated with Claude Code
https://claude.ai/code/session_019XsakwFGwtESwZ1gSYwG4o