Repository navigation
feat: shared profile order and Home's VS Code Profiles section - #132
Conversation
Default comes first, the Agents window profile second, and every other profile follows in a case-insensitive natural sort. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQkVogxxACrrFCdh1xebk1
…d buttons Home's first section is now headed "VS Code Profiles" without the "Profiles" subheading. Profile names are plain text, and the pencil is a native button. Home's buttons take VS Code's text-button shape, capped at the 300px width VS Code gives buttons in its views, and the workspace card's manifest actions become secondary buttons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQkVogxxACrrFCdh1xebk1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQkVogxxACrrFCdh1xebk1
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | ✅ -2 (≤ 100 complexity) |
| Duplication | ✅ 0 (≤ 1 duplication) |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Comments are now complete sentences. The comparator is named for what it does and compares at base sensitivity. Buttons inherit the VS Code font, and the manifest button row counts its padding inside the 300px cap so it lines up with Open Extension Matrix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQkVogxxACrrFCdh1xebk1
Resolve the conflicts with #131 and #132 in src/core/inventory.ts and test/unit/inventory.test.ts by keeping both sides: the category and install-source helpers and tests from this branch, and the profile display order helper and tests from main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQkVogar99mrwNEBNs4Pra
Closes #125
This is PR 6 in the Extension Matrix filters plan. The plan's out-of-scope list was treated as settled, so nothing else in Home, the PowerShell profiles feature, or the orphan cleanup view changed.
Profile order
composeInventorynow sorts the named profiles once, so Home and the matrix share one order. Default comes first, the Agents window profile (matched by itsbuiltin/agentslocation, not by name) comes second, and every other profile follows in a case-insensitive natural sort throughIntl.Collatorwithnumeric: true. The tests were written first ininventory.test.tsand cover Default first, the Agents window profile second, natural number order, mixed case, the Agents window setting turned off (throughwithoutAgentsWindowProfile), and a user profile named "Agents" that must not be promoted. Two existing tests encoded the old registry order and were updated to the new order.Home
homeView.tsdoc comment now describes several sections, and the Home entry inGLOSSARY.mduses the new name.buttonwith the same accessible name as before, styled like a VS Code view toolbar action. The read-onlyextensions.jsonview went with the name link, as accepted on 2026-11-15, so the unusedopenProfileReadOnlymessage and its handler were removed.Where the button values come from
Both values come from VS Code 1.146.0, the latest stable release when this was written.
.welcome-view-content > .button-container { width: 100%; max-width: 300px; }and the same cap on the.monaco-buttoninside it, inviews.csslines 100–115. VS Code also lifts the cap when a view is wider than 640px (viewPane.tstoggles awideclass). This PR does not copy that behavior, because the issue asks for the buttons to stop growing at the maximum..monaco-text-buttonusesborder-radius: 4pxandpadding: 4px 8pxinbutton.csslines 6–11 at 1.146.0. It was 2px with 4px padding at 1.101.0, the engine minimum. I matched current VS Code. Switching to 2px is a one-line change if you prefer the plan's value.Workspace card manifest actions: now secondary buttons
I changed Open manifest and Edit manifest from text links to VS Code secondary buttons (
--vscode-button-secondary*), with the same shape as Open Extension Matrix and capped together at the same 300px.buttonelements that only looked like links, so the old style hid what they were. Links also read as navigation, while these open an editor.Verification
npm run lintandnpm testpass on this branch (298 tests).npm run test:integrationpasses (3 of 3) against VS Code 1.146.0. The Linux VM on your machine lacks GTK, so I ran it in the cloud workspace from the same commit. There, one unrelated unit test (powershellFiles, the unreadable linked target) fails only because that container runs as root, which ignores file permissions.button. This is not a substitute for the checks below.Code review
A two-axis review (standards and spec) against
mainfound no hard violations and no missing requirements. The follow-up commit makes the new comments complete sentences, renames the comparator tocompareProfilesForDisplayand setssensitivity: 'base', gives buttonsfont: inheritso they use the VS Code font instead of the browser's default button font, and counts the manifest row's padding inside the 300px cap so it lines up with Open Extension Matrix. Extensions still sort withtoLowerCase().localeCompare, so numbered extension names do not get natural order. I left that alone because it is outside this ticket.Manual checks for Sam
🤖 Generated with Claude Code
https://claude.ai/code/session_01PQkVogxxACrrFCdh1xebk1