Skip to content

feat: shared profile order and Home's VS Code Profiles section - #132

Merged
SamErde merged 5 commits into
mainfrom
feat/125-profile-order-home-section
Nov 17, 2026
Merged

SamErde merged 5 commits into
mainfrom
feat/125-profile-order-home-section

Conversation

@SamErde

@SamErde SamErde commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Closes #125

This is PR 6 in the Extension Matrix filters plan. The plan's out-of-scope list was treated as settled, so nothing else in Home, the PowerShell profiles feature, or the orphan cleanup view changed.

Profile order

composeInventory now sorts the named profiles once, so Home and the matrix share one order. Default comes first, the Agents window profile (matched by its builtin/agents location, not by name) comes second, and every other profile follows in a case-insensitive natural sort through Intl.Collator with numeric: true. The tests were written first in inventory.test.ts and cover Default first, the Agents window profile second, natural number order, mixed case, the Agents window setting turned off (through withoutAgentsWindowProfile), and a user profile named "Agents" that must not be promoted. Two existing tests encoded the old registry order and were updated to the new order.

Home

  • The first section is headed "VS Code Profiles," and the "Profiles" subheading is gone. The element IDs are unchanged. The homeView.ts doc comment now describes several sections, and the Home entry in GLOSSARY.md uses the new name.
  • Profile names are plain text. The pencil is a native button with the same accessible name as before, styled like a VS Code view toolbar action. The read-only extensions.json view went with the name link, as accepted on 2026-11-15, so the unused openProfileReadOnly message and its handler were removed.
  • Open Extension Matrix stays under the heading and is full width up to a 300px maximum. The high-contrast border from fix: outline buttons in high-contrast themes #118 is unchanged.

Where the button values come from

Both values come from VS Code 1.146.0, the latest stable release when this was written.

  • Maximum width (300px). VS Code caps the buttons in its views' welcome content at 300px: .welcome-view-content > .button-container { width: 100%; max-width: 300px; } and the same cap on the .monaco-button inside it, in views.css lines 100–115. VS Code also lifts the cap when a view is wider than 640px (viewPane.ts toggles a wide class). This PR does not copy that behavior, because the issue asks for the buttons to stop growing at the maximum.
  • Shape (4px radius, 4px by 8px padding). ⚠️ This differs from the issue and the plan, which say 2px. VS Code's .monaco-text-button uses border-radius: 4px and padding: 4px 8px in button.css lines 6–11 at 1.146.0. It was 2px with 4px padding at 1.101.0, the engine minimum. I matched current VS Code. Switching to 2px is a one-line change if you prefer the plan's value.

Workspace card manifest actions: now secondary buttons

I changed Open manifest and Edit manifest from text links to VS Code secondary buttons (--vscode-button-secondary*), with the same shape as Open Extension Matrix and capped together at the same 300px.

  • They were already button elements that only looked like links, so the old style hid what they were. Links also read as navigation, while these open an editor.
  • Secondary styling keeps Open Extension Matrix as the one primary action in the section, so the card does not compete with it.
  • The card-wide button above them stays as it is, because it is the card itself rather than a standard button.
  • At a narrow sidebar width, the two buttons stack instead of wrapping their labels onto two lines.

Verification

  • npm run lint and npm test pass on this branch (298 tests).
  • npm run test:integration passes (3 of 3) against VS Code 1.146.0. The Linux VM on your machine lacks GTK, so I ran it in the cloud workspace from the same commit. There, one unrelated unit test (powershellFiles, the unreadable linked target) fails only because that container runs as root, which ignores file permissions.
  • I took a quick Playwright render of Home with stubbed theme variables at 260px and 700px. Open Extension Matrix measured 212px and then capped at 300px, and the pencil rendered as a button. This is not a substitute for the checks below.

Code review

A two-axis review (standards and spec) against main found no hard violations and no missing requirements. The follow-up commit makes the new comments complete sentences, renames the comparator to compareProfilesForDisplay and sets sensitivity: 'base', gives buttons font: inherit so they use the VS Code font instead of the browser's default button font, and counts the manifest row's padding inside the 300px cap so it lines up with Open Extension Matrix. Extensions still sort with toLowerCase().localeCompare, so numbered extension names do not get natural order. I left that alone because it is outside this ticket.

Manual checks for Sam

  • The Home profile list and the matrix columns show the same order.
  • NVDA: the heading list shows "VS Code Profiles" with no "Profiles" subheading.
  • NVDA: the Home pencil button is reachable by Tab and activates with Enter or Space.
  • Themes: in Light, Dark, High Contrast Dark, and High Contrast Light, Home's buttons have the standard shape and keep their high-contrast border, and they look consistent with the workspace card buttons.
  • Sidebar width: at a narrow and a wide width, Home's buttons stop growing at 300px, and the manifest buttons stack cleanly when narrow.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PQkVogxxACrrFCdh1xebk1

SamErde and others added 3 commits November 17, 2026 01:16
Default comes first, the Agents window profile second, and every other
profile follows in a case-insensitive natural sort.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PQkVogxxACrrFCdh1xebk1
…d buttons

Home's first section is now headed "VS Code Profiles" without the
"Profiles" subheading. Profile names are plain text, and the pencil is a
native button. Home's buttons take VS Code's text-button shape, capped at
the 300px width VS Code gives buttons in its views, and the workspace
card's manifest actions become secondary buttons.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PQkVogxxACrrFCdh1xebk1
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b091a333-aaef-4150-b8e9-59e035d6467b
Commits

Reviewing files that changed from the base of the PR and between fcd68f4 and 486ec0f.

Files selected for processing: 6

  • GLOSSARY.md
  • src/core/inventory.ts
  • src/panel/homeView.ts
  • src/protocol.ts
  • src/webview/home.ts
  • test/unit/inventory.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T02:01:22.380992Z 486ec0f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

codacy-production Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -2 complexity · 0 duplication

Metric Results
Complexity ✅ -2 (≤ 100 complexity)
Duplication ✅ 0 (≤ 1 duplication)

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

SamErde and others added 2 commits November 17, 2026 01:33
Comments are now complete sentences. The comparator is named for what it does and compares at base sensitivity. Buttons inherit the VS Code font, and the manifest button row counts its padding inside the 300px cap so it lines up with Open Extension Matrix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PQkVogxxACrrFCdh1xebk1
@SamErde
SamErde merged commit ec1fb02 into main Nov 17, 2026
9 checks passed
@SamErde
SamErde deleted the feat/125-profile-order-home-section branch November 17, 2026 02:04
SamErde added a commit that referenced this pull request Nov 17, 2026
Resolve the conflicts with #131 and #132 in src/core/inventory.ts and
test/unit/inventory.test.ts by keeping both sides: the category and
install-source helpers and tests from this branch, and the profile
display order helper and tests from main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PQkVogar99mrwNEBNs4Pra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shared profile order and Home's VS Code Profiles section

1 participant