Repository navigation
feat: accessible Extension Matrix cells with distinct states - #131
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQkVokrETpZkxBtYS6wy8y
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQkVokrETpZkxBtYS6wy8y
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQkVokrETpZkxBtYS6wy8y
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQkVokrETpZkxBtYS6wy8y
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Not up to standards ⛔🟢 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 7 minor |
| Complexity | 3 medium |
🔴 Metrics 86 complexity · 2 duplication
Metric Results Complexity ✅ 86 (≤ 100 complexity) Duplication ⚠️ 2 (≤ 1 duplication)
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Applied-to-all cells read as applied to all profiles in every column, a profile registry read error gives its own reason instead of claiming an extension list could not be read, read-only cells carry screen-reader text alongside their aria-label, and new doc comments are full sentences. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQkVokrETpZkxBtYS6wy8y
Resolve the conflicts with #131 and #132 in src/core/inventory.ts and test/unit/inventory.test.ts by keeping both sides: the category and install-source helpers and tests from this branch, and the profile display order helper and tests from main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQkVogar99mrwNEBNs4Pra
Closes #123
This is PR 1 in the Extension Matrix filters, grouping, and accessibility plan. It lays down the accessible table markup that later matrix PRs build on.
What changed
th scope="row", and the column headers carryscope="col"inside athead. Only head-row cells stick to the top, and row headers stick to the left with body text weight.crosshair.ts(gridHitAtandpaintCrosshair). A row header is classified as the extension's name rather than as a column header, and it is painted as the row's label.aria-labelthat names the extension, the profile, and the state, and the same text is written as screen-reader-only content, matching the workspace column's pattern. The Agents window profile is named "Agents window" in these labels.CellVmnow separates what is known about an install (installed,notInstalled, orunknown) from why the cell cannot act (readOnlyReason). Profiles that inherit from an unreadable Default are unknown as well. A duplicate-name warning now explains the name problem, and a profile registry read error (nowkind: 'profileRegistry') gives its own reason, instead of either one claiming that the extension list could not be read. Applied-to-all cells show ◆ in every profile, including profiles that use Default's extensions, because VS Code applies those extensions everywhere.src/webview/matrixTable.ts, andtest/unit/matrixTable.test.tsis a new jsdom harness modeled onpowershellRender.test.ts.Focus restoration across rebuilds and the hover card's Escape behavior are untouched, because they belong to #126. Nothing in the matrix implies that profiles should match, and the column headers still show no per-profile counts.
Verification
npm run lintpasses.npm testpasses (23 files and 314 tests) on the Windows-side Linux VM. In the cloud container, which runs as root, one existing PowerShell file-permission test fails because root can read any file; it does not touch this change.npm run test:integrationpasses under Xvfb on Linux with VS Code 1.146.0 (3 tests, exit code 0), both before and after the review fixes.main, and its findings are fixed in the last commit. TheALLbadge text predates this PR and is left as is.Manual checks for Sam
🤖 Generated with Claude Code
https://claude.ai/code/session_01PQkVokrETpZkxBtYS6wy8y