Skip to content

feat: accessible Extension Matrix cells with distinct states - #131

Merged
SamErde merged 5 commits into
mainfrom
feat/123-matrix-accessible-cells
Nov 17, 2026
Merged

SamErde merged 5 commits into
mainfrom
feat/123-matrix-accessible-cells

Conversation

@SamErde

@SamErde SamErde commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Closes #123

This is PR 1 in the Extension Matrix filters, grouping, and accessibility plan. It lays down the accessible table markup that later matrix PRs build on.

What changed

  • Row headers. Each extension's name cell is now a th scope="row", and the column headers carry scope="col" inside a thead. Only head-row cells stick to the top, and row headers stick to the left with body text weight.
  • Crosshair. Hit testing and highlight painting moved into crosshair.ts (gridHitAt and paintCrosshair). A row header is classified as the extension's name rather than as a column header, and it is painted as the row's label.
  • Accessible names. Each writable checkbox is named for its extension and profile (for example, "Beta in Work") and keeps its native checked state. Every other cell has an aria-label that names the extension, the profile, and the state, and the same text is written as screen-reader-only content, matching the workspace column's pattern. The Agents window profile is named "Agents window" in these labels.
  • Cell model. CellVm now separates what is known about an install (installed, notInstalled, or unknown) from why the cell cannot act (readOnlyReason). Profiles that inherit from an unreadable Default are unknown as well. A duplicate-name warning now explains the name problem, and a profile registry read error (now kind: 'profileRegistry') gives its own reason, instead of either one claiming that the extension list could not be read. Applied-to-all cells show ◆ in every profile, including profiles that use Default's extensions, because VS Code applies those extensions everywhere.
  • Glyphs and legend. Applied-to-all (◆), inherited (⤷), installed but locked (✓), not installed (—), and unknown (?) cells each have a distinct shape, and a short legend sits above the table. Glyphs use the description color instead of opacity, so they stay legible in high-contrast themes. Checkbox focus uses the theme's focus border.
  • Testable renderer. The table renderer moved to src/webview/matrixTable.ts, and test/unit/matrixTable.test.ts is a new jsdom harness modeled on powershellRender.test.ts.

Focus restoration across rebuilds and the hover card's Escape behavior are untouched, because they belong to #126. Nothing in the matrix implies that profiles should match, and the column headers still show no per-profile counts.

Verification

  • npm run lint passes.
  • npm test passes (23 files and 314 tests) on the Windows-side Linux VM. In the cloud container, which runs as root, one existing PowerShell file-permission test fails because root can read any file; it does not touch this change.
  • npm run test:integration passes under Xvfb on Linux with VS Code 1.146.0 (3 tests, exit code 0), both before and after the review fixes.
  • A two-axis code review (standards and spec) ran against main, and its findings are fixed in the last commit. The ALL badge text predates this PR and is left as is.

Manual checks for Sam

  • NVDA on Windows announces each cell with its extension name, profile name, and state, and announces the extension name as a row header when moving across a row.
  • NVDA announces each checkbox as " in " with its checked state.
  • In the Light theme, the glyphs, the legend, and the checkbox focus ring are legible.
  • In the Dark theme, the glyphs, the legend, and the checkbox focus ring are legible.
  • In the Light High Contrast theme, the glyphs, the legend, and the checkbox focus ring are legible.
  • In the Dark High Contrast theme, the glyphs, the legend, and the checkbox focus ring are legible.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PQkVokrETpZkxBtYS6wy8y

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 999bfa93-0471-41b4-a30b-dfbf8cb64cc8
Commits

Reviewing files that changed from the base of the PR and between 49af2a6 and 1eb3147.

Files selected for processing: 11

  • src/core/inventory.ts
  • src/core/inventoryQueries.ts
  • src/core/types.ts
  • src/webview/crosshair.ts
  • src/webview/main.ts
  • src/webview/matrixTable.ts
  • src/webview/render.ts
  • src/webview/style.css
  • test/unit/inventory.test.ts
  • test/unit/matrixTable.test.ts
  • test/unit/render.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T01:36:32.231317Z 1eb3147 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

codacy-production Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Not up to standards ⛔

🟢 Issues 3 medium · 7 minor

Results:
10 new issues

Category Results
CodeStyle 7 minor
Complexity 3 medium

View in Codacy

🔴 Metrics 86 complexity · 2 duplication

Metric Results
Complexity ✅ 86 (≤ 100 complexity)
Duplication ⚠️ 2 (≤ 1 duplication)

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Applied-to-all cells read as applied to all profiles in every column, a
profile registry read error gives its own reason instead of claiming an
extension list could not be read, read-only cells carry screen-reader
text alongside their aria-label, and new doc comments are full sentences.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PQkVokrETpZkxBtYS6wy8y
@SamErde
SamErde merged commit fcd68f4 into main Nov 17, 2026
8 of 9 checks passed
@SamErde
SamErde deleted the feat/123-matrix-accessible-cells branch November 17, 2026 01:56
SamErde added a commit that referenced this pull request Nov 17, 2026
Resolve the conflicts with #131 and #132 in src/core/inventory.ts and
test/unit/inventory.test.ts by keeping both sides: the category and
install-source helpers and tests from this branch, and the profile
display order helper and tests from main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PQkVogar99mrwNEBNs4Pra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension Matrix: accessible cells and distinct cell states

1 participant