Repository navigation
Fix instant kill exploit for Potions/Splash Potions/Lingering Potions - #14411
Closed
Mickey42302 wants to merge 2 commits into
Closed
Mickey42302 wants to merge 2 commits into
Mickey42302 wants to merge 2 commits into
Conversation
Contributor
|
Thank you for the PR but I don't see much need in patching this. If we wanted to patch this, the place would be in the computation of the amplifier by making it overflow save instead of limiting this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to suggest adding these patches to Paper. At present, there is an integer overflow exploit with potions. This is often used by trolls to create "Instant Kill" potions. These potions can kill any player, even in Creative mode.
This patch corrects the integer overflow, which makes it so that the "Instant Kill" potions no longer work.