Skip to content

ogc: linux-unstable: fix sync safe.directory + pin Fedora to 24.04 - #24

Open
scardracs wants to merge 2 commits into
OpenGamingCollective:masterfrom
scardracs:ci/sync-safe-directory
Open

scardracs wants to merge 2 commits into
OpenGamingCollective:masterfrom
scardracs:ci/sync-safe-directory

Conversation

@scardracs

@scardracs scardracs commented Oct 27, 2026 •

Copy link
Copy Markdown

Summary

  • Fix the daily Sync linux-next -> master failure at Configure upstream (fatal: detected dubious ownership) by marking $GITHUB_WORKSPACE as a git safe.directory in the Arch container job.
  • Pin the Fedora package job host to ubuntu-24.04 so sha512hmac (libkcapi AF_ALG) works again; ubuntu-latest (26.04) fails with Allocation of hmac(sha512) cipher failed and blocks the release gate.

Broken runs:

Test plan

  • Merge this PR
  • Re-run sync (workflow_dispatch or next schedule); confirm Configure upstream passes
  • Re-run / wait for Build & release; confirm Fedora %install gets past sha512hmac vmlinuz on ubuntu-24.04

The Arch container job fails at "Configure upstream" with dubious
ownership because actions/checkout and the container user differ.

Signed-off-by: Marco Scardovi <scardracs@disroot.org>
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 44 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: da60ecb5-6c64-4f6a-99ee-5dc085edd450
Commits

Reviewing files that changed from the base of the PR and between 5c7df57 and 2658da7.

Files selected for processing: 1
  • .github/workflows/build-fedora-packages.yml

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 999e1f23-b433-48a4-8477-a0f7d06995e6
Commits

Reviewing files that changed from the base of the PR and between eb5ca21 and 5c7df57.

Files selected for processing: 1
  • .github/workflows/sync-linux-next.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The upstream sync workflow adds $GITHUB_WORKSPACE to Git’s global safe.directory list before configuring the upstream remote.

Changes: Upstream sync workflow

Layer / File(s) Summary
Git safety setup
.github/workflows/sync-linux-next.yml
The workflow marks $GITHUB_WORKSPACE as a globally safe Git directory before configuring the upstream remote.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

Merge Risk: Minimal · previous review 5c7df

The workspace is marked safe before the workflow’s subsequent Git commands.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Title check Warning The title correctly mentions the safe.directory fix, but it also claims that Fedora is pinned to 24.04. The changeset does not include that change. Remove pin Fedora to 24.04 from the title, or include the corresponding Fedora pin change in the pull request.
Passed Passed checks: 3 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use path_filters to narrow the review scope.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

sha512hmac (libkcapi) talks to the host kernel via AF_ALG; on
ubuntu-latest (26.04) cipher allocation fails and RPM %install aborts.

Signed-off-by: Marco Scardovi <scardracs@disroot.org>
@scardracs scardracs changed the title ogc: linux-unstable: mark workspace safe for sync git steps ogc: linux-unstable: fix sync safe.directory + pin Fedora to 24.04 Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant