Repository navigation
fix: read the invoked model path once for staleness checks - #368
Open
rksharma-owg wants to merge 1 commit into
Open
rksharma-owg wants to merge 1 commit into
rksharma-owg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
python models/model.py --stale_days 2looks formodels/models/model.pyand returns[ERROR]._stalejoins the model directory tosys.argv[0], although the invocation path already contains that directory.Read the invocation path directly, retaining the existing model-relative
sourceFileslookup. Six real CLI tests cover directory,./prefix, nested-directory and space-containing paths, plus current-directory and absolute-path controls.Validation for
8185eefb2c13cfe62a4a9e921d4194a70c64dc75, based on381dea05c58055ba218e632510dd3a327d2bf215:Existing full-file Black formatting drift in
pytm/tm.pyis identical on baseline and patch; the changed assignment adds none. The adopted CI has no formatting gate. Optional CodeSee requires an upstream secret and was not run in the fork.This was discovered during CLI testing; no existing issue or competing fix was found. The contribution changes one production line and adds the regression tests, with no workflow or dependency changes.