Skip to content

Revert "Add WarpTails" - #1317

Merged
RBendias merged 2 commits into
mainfrom
revert-1151-clorenz/kumo-prior-03-warp-tails
Oct 30, 2026
Merged

RBendias merged 2 commits into
mainfrom
revert-1151-clorenz/kumo-prior-03-warp-tails

Conversation

@RBendias

Copy link
Copy Markdown
Collaborator

Reverts #1151

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.39%. Comparing base (7f3c8cd) to head (1652e40).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1317      +/-   ##
==========================================
- Coverage   82.44%   82.39%   -0.05%     
==========================================
  Files         186      185       -1     
  Lines       11811    11773      -38     
==========================================
- Hits         9737     9700      -37     
+ Misses       2074     2073       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 7f3c8cd and c93eaec.

Files selected for processing: 6
  • .agents/skills/processor-development/SKILL.md
  • sdm/processing/__init__.py
  • sdm/processing/numerical/__init__.py
  • sdm/processing/numerical/warp.py
  • test/processing/numerical/test_warp.py
  • test/processing/test_contract.py
Files with no reviewable changes: 5
  • test/processing/test_contract.py
  • sdm/processing/numerical/warp.py
  • sdm/processing/init.py
  • test/processing/numerical/test_warp.py
  • sdm/processing/numerical/init.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Changes
    • Removed the WarpTails numerical processor. It is no longer available through the processing packages or included in processor contract checks.
    • Updated the processor-development guidance to no longer recommend consulting model-specific libraries when defining processor requirements and numerical behavior.

The PR removes WarpTails from its implementation, package exports, and associated tests. It also revises processor-development guidance to remove a reference to model-specific libraries.

Changes: WarpTails removal

Layer / File(s) Summary
Remove WarpTails
sdm/processing/numerical/warp.py, sdm/processing/numerical/__init__.py, sdm/processing/__init__.py, test/processing/numerical/test_warp.py, test/processing/test_contract.py
The WarpTails implementation and public exports are removed. Its dedicated test and processor contract case are also removed.

Processor-development guidance

Layer / File(s) Summary
Revise processor-development guidance
.agents/skills/processor-development/SKILL.md
The “Learn from existing processors” guidance no longer directs readers to model-specific libraries for processor needs and numerical semantics.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: Minimal · previous review c93ea

The revert consistently removes WarpTails without an identified current-head risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the primary change: reverting the addition of the WarpTails processor.
Description check Passed The description states that the pull request reverts the related change, which matches the removal of WarpTails and its tests and exports.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@copy-pr-bot

copy-pr-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@RBendias
RBendias merged commit d147691 into main Oct 30, 2026
5 checks passed
@RBendias
RBendias deleted the revert-1151-clorenz/kumo-prior-03-warp-tails branch October 30, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant