Repository navigation
Share: exports and links show a comparison the way the screen does - #618
Draft
BhattaraiSijan wants to merge 5 commits into
Draft
BhattaraiSijan wants to merge 5 commits into
BhattaraiSijan wants to merge 5 commits into
Conversation
… each side's pin (#615)
BhattaraiSijan
marked this pull request as draft
November 5, 2026 20:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #614, #615, #616. Part of #613.
Summary
With comparison on, the Share button's three actions now produce what the screen shows. Before, all three succeeded and were silently wrong: the PNG/PDF held the bare basemap with no data, the legend band listed every switched-on layer at the global date, and the link opened a plain map with both sides' layers stacked.
No data at <date>for a side with nothing at its date. A side's pinned date is dated from the pin, not from the window core last requested for the layer.getUrlStringwrites mode, layout, the two layers, the compare date, the swap and the divider position as a|-separated entry (thetools=list is split on commas). On load, once mission load registers the tool handlers, the tool reads its entry back over a newtool:getUrlStaterequest, seeds its panel, asks core to show the plugin, and applies the divider after the enable settles, since enabling resets it. A layer the mission no longer draws leaves its side empty with a console warning.tools=entry was assembled from a list only the classic layout's init fills, so no modern tool could contribute. The modern controller now adds a tool to that list when it loads it and removes it when it destroys it. This is the one change outside the comparison code.Not in this PR
feat/scale-bar; comparison exports carry them once both branches are on development.Test plan
npx vitest run tests/unit src/essence: 218 files, 3684 tests pass🤖 Generated with Claude Code