Repository navigation
Pull TurboWarp security and correctness fixes and the forkphorus test suite - #38
Merged
Merged
Conversation
Fixes TurboWarp#358 (cherry picked from commit c5bf9c3)
…Warp#369) Fixes TurboWarp#356 (cherry picked from commit 984e05f)
Fixes TurboWarp#361 (cherry picked from commit 8c62a15)
…p#371) They both should convert to 0 Fixes TurboWarp#359 (cherry picked from commit 32b5428)
fix TurboWarp#380 (cherry picked from commit 042235b)
…urboWarp#383) (cherry picked from commit 7d0d67a)
(cherry picked from commit cb8a394)
(cherry picked from commit 55fd9b7)
(cherry picked from commit 984b4f4)
(cherry picked from commit f26ff67)
(cherry picked from commit cecd467)
Ported from TurboWarp ce39f14 (TurboWarp#399, Improve extension error handling). MistWarp's unsandboxed loader already catches runtime errors by script name, and its failure path already lets a failed extension load again, so only the sandboxed iframe path changes: it now loads scripts through upstream's tw-load-script-element, which rejects as soon as the script throws instead of leaving the load waiting. (cherry picked from commit ce39f14)
Ported from TurboWarp 0cb82af (TurboWarp#400, Query security manager extension permissions concurrently). MistWarp keeps its own loading model, where a denied or failing extension is recorded and the project still opens, but now asks the security manager about all of a project's custom extensions together, so it can combine them into one prompt, instead of one after another. Also uses tap assertions in the canEmbed test from 984b4f4. (cherry picked from commit 0cb82af)
(cherry picked from commit e9c6e12)
forkphorus has its own test suite, most of which are regression tests for real bugs in a real compiler so it may be worth testing against. forkphorus-befunge-eratosthenes and forkphorus-string-functions are probably the most meaningful new test cases; at the very least i wouldn't have needed a new test case in TurboWarp#300 to see changes in snapshots if they were merged The tests also add coverage for specializations like "delete 1 of list" that somehow weren't in the suite before? (cherry picked from commit 8ce06bc)
MistWarp code carries no comments, so the explanatory comments and JSDoc lines that came with the TurboWarp ports are removed; tool directives stay.
Adds snapshots for the forkphorus fixtures and removes one for a fixture that does not exist. No existing compiler output changes.
Mistium
force-pushed
the
upstream-fixes
branch
from
November 1, 2026 06:48
a241aa4 to
7b40cee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #37.
The first batch of TurboWarp
developcommits since our last common point (11 July): security fixes, correctness fixes, the forkphorus test suite andaddAddonBlockargument defaults. Every commit keeps upstream's message and acherry picked fromline.984b4f43Always rejectjavascript:URLs incanEmbedf26ff67eFix some limited prototype pollutionnode:testto taptw-load-script-element, which rejects as soon as the script throwse9c6e122Argument defaults inaddAddonBlockiroptimizer.js, TurboWarp#371jsgen.js), MistWarp's more precise version is kept, and upstream's fixtures and snapshots now run against itAlso in this batch
Checks
npx eslint srcand the conventions check are clean.node test/snapshot: 216/216.test/integration/execute.js: 306/306, including the forkphorus fixtures.develop.developover 5 runs.Still to come, as separate stacked PRs: compiler performance (TurboWarp#384, TurboWarp#391, TurboWarp#392, TurboWarp#389, with TurboWarp#395), the sampler API (TurboWarp#394), and moving tests to
node:test(TurboWarp#393).