Repository navigation
fix: apply grid worker skeleton filters independently - #11
Draft
afonsobspinto wants to merge 1 commit into
Draft
afonsobspinto wants to merge 1 commit into
afonsobspinto wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Draft for internal review before opening against upstream
catmaid/CATMAID:dev. The worker condition fix is already included infeature/new-ingestion(PR #7). This PR isolates that fix and adds focused regression coverage for upstream preparation.Problem and resulting behavior
The normal grid cache worker checks
n_last_edited_skeletons_limitbefore readingn_largest_skeletons_limit, although the filters are independently configurable. As a result, configuring only the largest-skeleton filter silently drops it; configuring only the last-edited filter attemptsint(None)and fails before refreshing the cell.n_largest_skeletons_limit=5.TypeErrorfromint(None)prevents refresh.n_last_edited_skeletons_limit=3.Changes
This PR contains no importer, cache transaction, migration or schema changes. It is independent of the cell publication changes in PR #9.
Validation
TypeError; the other two cases still pass.git diff --checkpassed.In a configured CATMAID environment, run:
python manage.py test catmaid.tests.test_cache_update_workerThe affected worker condition is also present in current upstream
dev. After internal review, cherry-pick this commit onto upstreamdevfor the upstream PR.