Repository navigation
MDEV-34654 perfschema.relaylog can fail based on the path of the build directory - #5921
Open
Swayam-code wants to merge 2 commits into
Open
Swayam-code wants to merge 2 commits into
Swayam-code wants to merge 2 commits into
Conversation
…d directory Match and display log basenames after normalizing path separators, so parent directory names cannot affect file selection or filename output. Use misleading datadir names to exercise filtering, extraction and relay-log rotation. Assisted-by: Codex:GPT-6
gkodinov
added
the
External Contribution
gkodinov
approved these changes
Oct 20, 2026
gkodinov
left a comment
gkodinov
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution! This is a preliminary review.
LGTM. Please stand by for the final review.
|
|
||
| select | ||
| substring(file_name, locate("slave-", file_name)) as FILE_NAME, | ||
| substring_index(replace(file_name, char(92), "/"), "/", -1) as FILE_NAME, |
Member
There was a problem hiding this comment.
nit: you could use "\" here: will make it easier to read. Or at least use the hex code ...
Author
There was a problem hiding this comment.
Fixed in cdbda03: replaced char(92) with 0x5c in the test and matching expected output.
Replace char(92) with 0x5c in the path normalization expressions and matching expected output, as suggested in review. Assisted-by: Codex:GPT-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perfschema.relaylogcan select unrelated files when parent directories containmaster-orslave-. Match and display normalized basenames, and use misleading datadir names to cover the regression.Tested all three binlog formats on Linux (11.4.13 and 13.2 Debug) and Windows (13.2 Debug). The 11.4 runs used the 13.2 test client.
MDEV-34654