Repository navigation
fix(calendar): recover from fetch errors promptly, track errors per calendar - #4342
Open
MikeBishop wants to merge 1 commit into
Open
MikeBishop wants to merge 1 commit into
MikeBishop wants to merge 1 commit into
Conversation
…alendar A single transient network error replaced the whole calendar with "No internet connection", and the message could linger after recovery because an unchanged events checksum skipped the redraw. - Track errors per calendar URL; clear and redraw on a successful fetch - Include url in CALENDAR_ERROR notifications - Add keepEventsOnError option (default false) to keep showing the last known events when a later fetch fails Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Collaborator
|
Thanks for the PR! Speaks something against enabling this behavior permanently and omit the new opt-in option? |
Contributor
Author
|
Considered that, but it means that the error isn't visible from the screen unless all calendars have failed from the start. Some people might prefer to see an error so they can fix it. Some visual cue that the shown events are stale might be an alternative. |
Collaborator
|
Good point. What do you think of using a small grace period instead of a new config option - e.g. keeping existing events for the first 2 or 3 consecutive fetch failures and only showing the error if it persists? That would handle transient glitches by default while still surfacing permanent errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sporadic "No internet connection." messages could blank the calendar after a single transient network error, and the message could linger after the connection came back.
urlin theCALENDAR_ERRORsocket notification so the front end can attribute errors to a calendar.keepEventsOnErroroption (defaultfalse, so current behavior is unchanged). Whentrue, the last known events stay visible after a failed fetch, and the error is only shown if there are no events to display.keepEventsOnError.No related issue.
🤖 Generated with Claude Code