Repository navigation
refactor: migrate calendar to ESM - #4340
Merged
Merged
Conversation
KristjanESPERANTO
force-pushed
the
esm
branch
from
November 11, 2026 14:43
d4320ed to
18e6685
Compare
Collaborator
Author
|
The jobs are failing - switching to Ubuntu 26 didn't solve the problem. Someone already opened an issue: actions/runner-images#15296 |
khassel
approved these changes
Nov 11, 2026
khassel
pushed a commit
that referenced
this pull request
Nov 12, 2026
While working on #4340, I took a closer look at the Calendar tests and saw potential for separating the DOM code from the logic that builds the time text. I extracted the time-formatting logic from `calendar.js` to `calendarutils.mjs` so it can be tested directly with unit tests. That let me replace 8 E2E tests with unit tests, which I find easier to understand. They are also faster. The remaining E2E tests still cover the whole path. I think there is more potential in this direction (e.g. the `dateheaders` path), but this PR is already big enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step in the ESM migration, following #4334 🙂
I've converted the Calendar module to ESM. After migrating
defaultmodules/calendar/debug.js, I noticed it was been broken since #3959 - I fixed it as well.