Repository navigation
library: Fix duplicated VkFormatProperties3 in format chain - #1055
Merged
Merged
Conversation
eliminateAliases appended each struct aliases list into the collected names, so a struct name was compared against lists and alias duplicates were never removed. Profiles using both 'VkFormatProperties3' and 'VkFormatProperties3KHR' chained the two aliases into VkFormatProperties2, breaking VUID-VkFormatProperties2-sType-unique. - Collect alias names with extend so alias duplicates are removed - Handle VkFormatProperties2 and VkFormatProperties3 in the format special case alongside their KHR aliases - Fill and compare a struct using data defined under any of its alias names, so the remaining struct keeps the profile data
Collaborator
|
CI VulkanProfiles build # 4655 running. |
christophe-lunarg
added
bug
Collaborator
|
CI VulkanProfiles build # 4655 passed. |
christophe-lunarg
force-pushed
the
fix-format-properties3-duplicate
branch
from
October 21, 2026 11:04
c80ab62 to
148f41b
Compare
Collaborator
|
CI VulkanProfiles build queued with queue ID 165314. |
1 similar comment
Collaborator
|
CI VulkanProfiles build queued with queue ID 165314. |
Collaborator
|
CI VulkanProfiles build # 4657 running. |
Collaborator
|
CI VulkanProfiles build # 4657 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eliminateAliases appended each struct aliases list into the collected names, so a struct name was compared against lists and alias duplicates were never removed. Profiles using both 'VkFormatProperties3' and 'VkFormatProperties3KHR' chained the two aliases into VkFormatProperties2, breaking VUID-VkFormatProperties2-sType-unique.