Repository navigation
vkprofiles: Fix empty profile pulling and noauto/exact member pulling - #1052
Merged
Merged
Conversation
christophe-lunarg
added
bug
Collaborator
|
CI VulkanProfiles build queued with queue ID 163379. |
1 similar comment
Collaborator
|
CI VulkanProfiles build queued with queue ID 163379. |
- transform --pull requirements: create a <profile>_requirements capability block for profiles that do not define any, so they receive the Vulkan core version requirements instead of staying empty. - Do not fill 'exact' (device specific values) and 'noauto' (not handled yet) structure members with unsupported default values; these produced invalid values (e.g. pointClippingBehavior = 0) and meaningless requirements (e.g. deviceUUID = []). - combine --mode difference: pair each profiles file with each of its own profiles when computing the common capabilities (KeyError when profile names differ across files). - Rename the generated requirements test profiles to VP_LUNARG_gen_min_requirements_*. - Add test_transform_pull_caps_exact_noauto.py, pulling the Vulkan 1.2 and 1.4 core requirements and checking that no 'exact' (device specific values) or 'noauto' (not handled yet) structure member is pulled, with and without 'ignore-unsupported'. Also check that unsupported default values are pulled only without 'ignore-unsupported'.
christophe-lunarg
force-pushed
the
fix-empty-profile-pulling
branch
from
October 20, 2026 13:17
4b59b5b to
510e4f0
Compare
Collaborator
|
CI VulkanProfiles build queued with queue ID 163391. |
1 similar comment
Collaborator
|
CI VulkanProfiles build queued with queue ID 163391. |
Collaborator
|
CI VulkanProfiles build # 4650 running. |
Collaborator
|
CI VulkanProfiles build # 4650 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.