Repository navigation
[Fix] Correct generic MTP future embeddings and empty-shard loss - #2178
Merged
jayhenry merged 1 commit intoOct 15, 2026
Merged
Conversation
jayhenry
added this pull request to stack #2179
October 15, 2026 03:59
This was referenced Oct 15, 2026
jayhenry
force-pushed
the
fix/mtp-local-future-embeddings
branch
from
October 15, 2026 04:21
b711032 to
c56b137
Compare
Co-authored-by: Kuang <128125671+Knlife@users.noreply.github.com>
jayhenry
force-pushed
the
fix/mtp-local-future-embeddings
branch
from
October 15, 2026 04:37
c56b137 to
e850591
Compare
YanhuiDua
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack #2179 (bottom to top):
fix/deepep-layout-event→mainfeat/glm53flash-materialize-full-f0→fix/deepep-layout-eventfeat/glm53flash-f3-kda→feat/glm53flash-materialize-full-f0feat/glm53flash-f4-mhc→feat/glm53flash-f3-kdafeat/glm53flash-f5-nope-dsa→feat/glm53flash-f4-mhcfeat/glm53flash-f1-vl-data→feat/glm53flash-f5-nope-dsafeat/glm53flash-f2-vision-tower→feat/glm53flash-f1-vl-datafix/mtp-local-future-embeddings→feat/glm53flash-f2-vision-tower← you are herefeat/glm53flash-f6-text-moe→fix/mtp-local-future-embeddingsSummary
This generic MTP layer follows the F2 vision layer. GLM-5.3-Flash specific MTP wiring and integration tests remain in F6.
Tests
tests/loss/test_mtp_e2e_tv_loss.py,tests/loss/test_mtp_empty_shards.pyandtests/model/test_mtp_local_future_embeddings.pypassed in the targeted CPU run.