Skip to content

Fix for S3Proxying with path style access - #12925

Open
qqmyers wants to merge 2 commits into
IQSS:developfrom
GlobalDataverseCommunityConsortium:TDL/s3proxyfix
Open

qqmyers wants to merge 2 commits into
IQSS:developfrom
GlobalDataverseCommunityConsortium:TDL/s3proxyfix

Conversation

@qqmyers

@qqmyers qqmyers commented Nov 20, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:
In v6.12.1 (and earlier) proxying was broken for single part uploads and downloads if path style access was used.

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer: Obvious in hindsight - the regex there looks for a protocol followed by a string (bucketname) and . followed by endpoint. If the url is https://endpointServer/bucketname/... as in path style access, there's no replacement done.

Suggestions on how to test this: The new tests should cover all the cases

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@qqmyers qqmyers moved this to Ready for Triage in IQSS Dataverse Project Nov 20, 2026
@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: 3 A percentage of a sprint. 2.1 hours.

Projects

Status: Ready for Triage

Development

Successfully merging this pull request may close these issues.

1 participant