Repository navigation
Conversation
The exported Search::Seq::RBS engine changes its constructor and layout, and the float rounding control changes for MSVC, so libraries built from this tree are not binary compatible with 6.5.0.
The development section opened for 7.0.0 holds only fixes and the opt-in strict option parsing, which go out as 6.6.0 on 16 November. Gecode 7.0.0 remains the next major release.
BaseOptions::parse(argc,argv) is not virtual, so the strict overload ran only the base parse for SizeOptions and InstanceOptions. Their size or instance argument was then reported as unrecognised, for example "prog 7" with SizeOptions::parse_strict(). Give SizeOptions and InstanceOptions their own strict overloads, which hide the base ones as their parse() already does. The only argument that may remain is the size, which must be a number, or the instance, which must not start with a hyphen so that a misspelled option is not taken as an instance. Making parse() virtual instead would recurse in subclasses whose parse() calls parse_strict(), such as EFPA's options.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare Gecode 6.6.0, a bug-fix release from the current tip of main, planned for 16 November 2026.
Search::Seq::RBSchanges its constructor and layout, and the float rounding control changes for MSVC.SizeOptionsandInstanceOptions.BaseOptions::parse(argc,argv)is not virtual, soparse_strict()ran only the base parse and rejected the size or instance argument. Both classes now have their own strict overloads: the only argument that may remain is the size (a number) or the instance (not starting with a hyphen). The changelog entry for strict parsing says so. New tests cover both classes.Validated locally with Release libraries, experimental search, Gist and the test libraries:
checkpasses 539/539.