Repository navigation
Honor propagation annotations in FlatZinc scheduling bindings - #266
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mandatory
gecode_cumulativespaths dropped propagation annotations when posting cumulative or unary constraints. As a result, requesting advanced propagation could leave an overload undetected until search, even though the underlying propagator can reject it at the root.Forward the requested propagation level through the fixed and variable-duration paths, including unary specializations. Also forward it through the older fixed-duration unary wrappers, both mandatory and optional. Calls without an annotation retain their default propagation level.
Add a regression that checks root propagation directly: basic propagation leaves the fixture undecided, while advanced and full propagation detect the overload. It fails before the fix and passes afterward.
Validation: all 22 native FlatZinc registry tests pass with five iterations and five runner threads; all 479 integrity tests pass. Source tidiness, generated-source freshness, and whitespace checks pass.