Repository navigation
Require and select a working C++17 mode in Autoconf builds - #265
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autoconf previously checked obsolete compiler minimum versions and treated the C++17 flag as optional. Replace those checks with a required compile probe for C++17 language and standard-library support.
Keep a capable default or user-selected newer standard. Otherwise, select C++17 using the compiler's appropriate flag; report a clear configure error if neither mode works. Keep the C++ standard flag out of CFLAGS. Regenerate
configurewith the repository's Autoconf 2.72 tooling.Validation with Apple Clang: an initial C++14 selection gains C++17, an explicit C++20 selection is preserved, and a compiler shim restricted to C++14 is rejected with the expected diagnostic. Source tidiness and generated-source freshness checks passed. Native MSVC validation was not available locally.