Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two tests that exercise Parsers behavior through repositories:
GetTermAggregationsAsync_WithRegexIncludeFilterAndIncludeResolver_ReturnsOnlyMatchingBuckets: the existing regex terms include test, but with a request-levelIncludeResolver. Fails withUnresolved includeuntilIncludeVisitorresolves terms aggregation@includeas a named include when the context has an include resolver Foundatio.Parsers#310 is fixed and released.FindAsync_WithLeadingWildcardOnAnalyzedAndKeywordFields_MatchesDocuments: leading wildcard on atextand akeywordfield. Fails with an Elasticsearch 400 on Parsers 8.0.2 (allow_leading_wildcard: false) and passes on Parsersmain(BREAKING: Apply query modifiers and preserve literal wildcards Foundatio.Parsers#291). See DefaultAllowLeadingWildcardstofalsenow that #291 honors it Foundatio.Parsers#311 about the default.Draft: both tests need a Parsers release, so this should go in after a Parsers version that contains the fixes is referenced here.