Skip to content

fix(cli): describe -e as not failing on errors - #31

Merged
Bonajo merged 1 commit into
mainfrom
fix/fail-on-error-help
Nov 15, 2026
Merged

Bonajo merged 1 commit into
mainfrom
fix/fail-on-error-help

Conversation

@Bonajo

@Bonajo Bonajo commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

codestripper --help described -e, --fail-on-error as "Fail if an error occurs during code stripping". The flag does the opposite: it is store_false, so failing is the default and -e turns it off. The help text now says "do NOT fail if an error occurs during code stripping", matching the README table and the wording of -r. Behaviour is unchanged; the flag name stays, because renaming it would break existing calls.

Tests in tests/test_main.py:

  • --help describes -e as not failing. This test fails on main.
  • Without -e, a file with an invalid tag (MissingClose.java) raises StripError.
  • With -e, the same file only logs the error.

Merging this releases 1.3.1, the first release through Trusted Publishing with PEP 740 attestations (#27).

@Bonajo
Bonajo merged commit dbcc043 into main Nov 15, 2026
29 checks passed
@Bonajo
Bonajo deleted the fix/fail-on-error-help branch November 15, 2026 10:01
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant