Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3435 +/- ##
==========================================
+ Coverage 75.10% 75.14% +0.03%
==========================================
Files 460 460
Lines 112030 112221 +191
Branches 17757 17777 +20
==========================================
+ Hits 84144 84330 +186
- Misses 27604 27609 +5
Partials 282 282 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ing set to simplex in Highs::getPrimalRayInterface
…ing set to simplex in Highs::getPrimalRayInterface
…k, since semi-variables can't contribute to ray
…getPrimalRayInterface (for Ray-464a) and restored it!
jajhall
marked this pull request as ready for review
October 22, 2026 09:14
filikat
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For the first of the asserts in #3413, the incumbent
solveroption was IPM, but crossover isn't used for infeasible problems, so the necessary basic solution required to compute a ray was unavailable. By ensuring that simplex is used, the failing assert is true.For the second of the asserts in #3413, may have
num_semi_infeasibilitiesbeing positive, butnum_primal_infeasibilitiesbeing zero. Enhanced the unit tests inissue-3413.Also simplified and corrected the saving and restoration of objective data and options changed when finding rays
Checklist
latestbranchRelated issue
#3413