Repository navigation
Mount tabs in project view lazily - #2020
Merged
Merged
Conversation
Makes tabs `lazy` so they mount only when activated. This prevents opening the project view eager-loading data for all tabs at once. As a side effect, this removes the counter badges on the tabs. With data no longer loaded eagerly, there's nothing to show for most views. Falling back to time series metrics as a source would lead to inconsistencies between tab contents and their counters, since metrics are calculated asynchronously. Signed-off-by: nscuro <nscuro@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mounts tabs in project view lazily.
Makes tabs
lazyso they mount only when activated. This prevents opening the project view eager-loading data for all tabs at once.As a side effect, this removes the counter badges on the tabs. With data no longer loaded eagerly, there's nothing to show for most views. Falling back to time series metrics as a source would lead to inconsistencies between tab contents and their counters, since metrics are calculated asynchronously.
Addressed Issue
N/A
Additional Details
N/A
Checklist
This PR introduces new or alters existing behavior, and I have updated the documentation accordingly