Repository navigation
Refactor various modals to proper forms - #2016
Merged
Merged
Conversation
Enables forms embedded in modals to behave as users expect, i.e. submit on enter, staying open until the submit action completes, and remaining open when submitting fails. Also removes various e2e tests added in previous changes that add little value or are too granular. Signed-off-by: nscuro <nscuro@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors various modals to proper forms.
Enables forms embedded in modals to behave as users expect, i.e. submit on enter, staying open until the submit action completes, and remaining open when submitting fails.
Also removes various e2e tests added in previous changes that add little value or are too granular.
Addressed Issue
N/A
Additional Details
N/A
Checklist
This PR introduces new or alters existing behavior, and I have updated the documentation accordingly