Repository navigation
Commit the design of following SPINE releases, as built - #7
Merged
Merged
Conversation
docs/designs/following-spine-releases.md is the design that pull requests 1 to 6 implemented: the library's version, the tests that survive expected SPINE changes, the fixture tooling for any tag, the dumper's new keys, the classifier and follow_spine.py, and CI. Its companion following-spine-releases.cafmaker-fields.tsv lists the 228 model fields the three CAFMakers read, from which tests/test_contracts.cpp was written. Updated before committing: - Status: implemented, in pull requests 1 to 6; v0.1.0 on the merge commit of pull request 2. - G2 and the v1.4.91 row (R8): a new NuInteractionScheme member needs its interaction tables in SPINE's Neutrino.resolve_enum, or the dumper stops with "cannot identify the enum of interaction_mode under ..." (checked on a copy of v1.4.0 with a member and no tables). - The table of open points R1-R16 says how each was fixed. - A new section, "As built", records where the code differs from the plan, pull request by pull request, and what the verification reached. The root EGM.md and the README index the new folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commits the design document behind pull requests 1 to 6, with two open points closed. Until now it was only in the author's working tree.
What changes
docs/designs/following-spine-releases.md(new) covers:follow_spine.py;Its companion
following-spine-releases.cafmaker-fields.tsvlists the 228 model fields the three CAFMakers read, from whichtests/test_contracts.cppwas written.Updated before committing:
NuInteractionSchememember needs its interaction tables in SPINE'sNeutrino.resolve_enum. Otherwise the dumper stops withcannot identify the enum of interaction_mode under ..., andfollow_spine.pyreportsdump_failed.The root
EGM.mdand the README index the newdocs/folder.No code changes.
Checked
NuInteractionScheme.MARLEYand no tables exits 1 withdump_schema: RuntimeError: cannot identify the enum of interaction_mode under MARLEY: []. The local tag v1.4.91, which adds the tables, ran tochangedin pull request 6's checks.EGM.mdresolve.