Skip to content

Update Splitter.split setter to be consistent #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yoelcortes merged 2 commits into from
Oct 10, 2026
Merged

Update Splitter.split setter to be consistent #260

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15436bc
update split setter to be consistent
yalinli2 Oct 10, 2026
8b900ae
use existing indexer instead of creating a new one; remove old uncess…
yoelcortes Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion biosteam/units/splitting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,14 @@ class Splitter(Unit):
Water 0.9
Ethanol 0.8

A dictionary can be used as well. As when creating the splitter,
chemicals that are not given are set to 0:

>>> S1.split = {'Ethanol': 0.99}
>>> S1.isplit.show()
SplitIndexer:
Ethanol 0.99

"""
_N_outs = 2
_graphics = splitter_graphics
Expand All @@ -152,7 +160,12 @@ def split(self):
@split.setter
def split(self, values):
split = self.split
if split is not values:
if isinstance(values, dict):
# Reset split (default for missing components is zero; same rule used in _init)
split[:] = 0
IDs, values = zip(*values.items())
self._isplit[IDs] = values
else:
split[:] = values

def _init(self, split, order=None):
Expand Down Expand Up @@ -388,6 +401,9 @@ def split(self):
def split(self, values):
split = self.split
if split is not values:
if isinstance(values, dict):
# Same rule as at creation: chemicals not given are set to 0
values = self.thermo.chemicals.isplit(values).data
split[:] = values

def _init(self, split, order=None, T=None, P=None, phases=None):
Expand Down
Loading