Repository navigation
Fix bugs related to flow_fractions - #258
Conversation
yoelcortes
left a comment
There was a problem hiding this comment.
Awesome, thanks reviewing recent commits and improving the code!!
|
@yalinli2, I just realized that the Would it be better to move the By the way, I have not been running QSDsan and making sure my changes are backwards compatible (sorry for the trouble!). I will start doing so again with future commits. Also, for any changes to core classes (e.g., Unit, Stream, TEA, System; not specific unit operations), I will plan on submitting a pull request for your review. Let me know if you have any specific BioSTEAM classes that would be helpful to keep track of with PRs (as opposed to direct commits on my side). Thank you! |
|
Thanks @yoelcortes ! I've updated QSDsan so it doesn't call Sounds good on the test and PR review! |
Two changes:
define_creditfunction, the doc says it can accept a function, but it couldn't, so I added a helper function for that.Unit._flow_fractionsattribute, it wasn't included in_init_resultsfunction, though other dict were included, It causes problems inqsdsansince it doesn't callUnit.__init__but_init_results. IfUnit._flow_fractionsshouldn't be added to_init_results, I can patch upqsdsan, thanks!