Repository navigation
Conversation
Collaborator
|
It compiles without any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The Chinese 09_Constant example assigns IMMUTABLE_NUM again in the constructor while leaving IMMUTABLE_BLOCK uninitialized. This causes the example to fail compilation under Solidity 0.8.x and disagrees with the working localized examples.
This PR replaces the erroneous constructor assignment with IMMUTABLE_BLOCK = block.number and updates the matching README code block.
Scope
No runtime dependency or unrelated cleanup is included.
Verification