Skip to content

GPU Metal: do not let Metal track hazards on the memory buffers #16068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Nov 6, 2026
Merged

GPU Metal: do not let Metal track hazards on the memory buffers #16068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions GPU/GPUTracking/Base/metal/GPUReconstructionMetal.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,14 @@ uint32_t metalGPUCoreCount()
}

// We only support internal GPUs, so the ownership of the memory is always shared
mInternals->mem_gpu = [mInternals->device newBufferWithLength:mDeviceMemorySize options:MTLResourceStorageModeShared];
mInternals->mem_gpu = [mInternals->device newBufferWithLength:mDeviceMemorySize options:MTLResourceStorageModeShared | MTLResourceHazardTrackingModeUntracked];
if (mInternals->mem_gpu == nil) {
GPUErrorReturn("Metal Memory Allocation Error");
}

// FIXME: until I understand how to enable the gGPUConstantMemBufferSize constexpr
int32_t tmpGPUConstantMemBufferSize = 100000; // gGPUConstantMemBufferSize
mInternals->mem_constant = [mInternals->device newBufferWithLength:tmpGPUConstantMemBufferSize options:MTLResourceStorageModeShared];
mInternals->mem_constant = [mInternals->device newBufferWithLength:tmpGPUConstantMemBufferSize options:MTLResourceStorageModeShared | MTLResourceHazardTrackingModeUntracked];
if (mInternals->mem_constant == nil) {
GPUErrorReturn("Metal Constant Memory Allocation Error");
}
Expand All @@ -143,7 +143,7 @@ uint32_t metalGPUCoreCount()
mInternals->streamHasWork[i] = false;
}

mInternals->mem_host = [mInternals->device newBufferWithLength:mHostMemorySize options:MTLResourceStorageModeShared];
mInternals->mem_host = [mInternals->device newBufferWithLength:mHostMemorySize options:MTLResourceStorageModeShared | MTLResourceHazardTrackingModeUntracked];
if (mInternals->mem_host == nil) {
GPUErrorReturn("Error allocating pinned host memory");
}
Expand Down
Loading