Skip to content

Improve version check logic - #234

Merged
ryanlua merged 1 commit into
1ForeverHD:mainfrom
ryanlua:version-check
Nov 14, 2026
Merged

ryanlua merged 1 commit into
1ForeverHD:mainfrom
ryanlua:version-check

Conversation

@ryanlua

@ryanlua ryanlua commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Adds a check to see if the version retrieved is actually newer and swaps from using a place to a Creator Store model for the version.

Fixes https://forum.hdadmin.com/p/6qpl5rzwtjzuwtg

Inspired by my own project's version check logic: https://github.com/ryanlua/purse/blob/HEAD/src/Attribution.client.luau

Warning

Before you merge this PR, the Creator Store model needs to be updated to include the asset version vX.X.X since the version check happens on the Creator Store asset instead of the TopbarPlus Playground place.

  • Update the Creator Store model to include asset version

Adds a check to see if the version retrived is actually newer and swaps from using a place to an Creator Store asset for the version

Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
@ryanlua
ryanlua requested a review from 1ForeverHD as a code owner November 13, 2026 21:44
@ryanlua
ryanlua marked this pull request as draft November 13, 2026 21:44
@ryanlua

ryanlua commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator Author

Looks like the model now has the version number. Everything should be good now.

@ryanlua
ryanlua marked this pull request as ready for review November 13, 2026 21:50
@ryanlua
ryanlua merged commit d4d5bb6 into 1ForeverHD:main Nov 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant