Repository navigation
Improve version check logic - #234
Merged
Merged
Conversation
Adds a check to see if the version retrived is actually newer and swaps from using a place to an Creator Store asset for the version Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
ryanlua
marked this pull request as draft
November 13, 2026 21:44
Collaborator
Author
|
Looks like the model now has the version number. Everything should be good now. |
ryanlua
marked this pull request as ready for review
November 13, 2026 21:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check to see if the version retrieved is actually newer and swaps from using a place to a Creator Store model for the version.
Fixes https://forum.hdadmin.com/p/6qpl5rzwtjzuwtg
Inspired by my own project's version check logic: https://github.com/ryanlua/purse/blob/HEAD/src/Attribution.client.luau
Warning
Before you merge this PR, the Creator Store model needs to be updated to include the asset version
vX.X.Xsince the version check happens on the Creator Store asset instead of the TopbarPlus Playground place.