Repository navigation
Update the desktop app in the background on Windows and Linux - #1160
Open
Ale Paredes (ale7714) wants to merge 3 commits into
Open
Ale Paredes (ale7714) wants to merge 3 commits into
Ale Paredes (ale7714) wants to merge 3 commits into
Conversation
The desktop app had no updater, so a fix such as 3.0.2's MPTCP change reached only users who reinstalled. electron-updater installs the Windows NSIS build and the Linux AppImage on quit, while macOS waits on the Developer ID signature that Squirrel.Mac requires. The main-process bundle gains a createRequire banner because the bundled CommonJS updater otherwise throws `Dynamic require of "fs"` at startup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: c3bd8e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The inline node step grew past 40 lines with the electron-updater metadata rewrite. As a script it gets prettier and eslint, and it fails on an unset PLATFORM or ARCH instead of naming bundles after "undefined". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The .deb is the more downloaded Linux bundle, and no apt repository serves it, so its users otherwise update only by hand. electron-updater's DebUpdater installs it with dpkg behind an administrator password prompt, keyed off the package-type file electron-builder writes into the package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 2, 2026
Contributor
|
Hey Ale Paredes (@ale7714) — CI is green and no reviewer is assigned yet. Could you request one when you have a chance? Auto-comment from overwatch. Will not re-nudge for 7 days. |
Ale Paredes (ale7714)
requested review from
Devin T. Currie (DTCurrie) and
Micheal Parks (micheal-parks)
November 5, 2026 16:49
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop app has no updater, so 3.0.2's MPTCP fix for CVE-2026-98432 reaches only people who reinstall. This adds electron-updater for the Windows installer build, the Linux AppImage, and the .deb, whose update runs dpkg behind an administrator password prompt. macOS stays off until the app has a Developer ID signature (APP-18424), since Squirrel.Mac rejects updates to an ad-hoc signed app. The portable exe cannot replace itself.
Installs from 3.0.2 or earlier have no updater, so the first automatic update ships with the release after this one.
Without the createRequire banner, the bundled updater throws
Dynamic require of "fs"as main.mjs loads; a Node smoke bundle reproduced that and passed with the banner. electron-builder 26.15.3 writes latest*.yml even with--publish never(PublishManager queues update info whatever the publish policy), and I ranscripts/name-release-bundles.mjsagainst fake Windows, Linux and macOS outputs. No real install has gone through an update yet. On Windows, will-quit stops draw-server before the NSIS installer runs, but I have not seen whether the installer ever meets a locked draw-server.exe.VIAM_VISUALIZER_NO_AUTO_UPDATEturns updates off, for a CLI-managed copy once rdk#6646 lands.🤖 Generated with Claude Code