Repository navigation
chore: update keywords - #13166
chore: update keywords#13166
Conversation
The `dxmy` package was missing the `multiplication` and `hadamard` keywords that the sibling `sxmy` package includes. Both packages implement the same element-wise multiplication (Hadamard product) operation for different floating-point precisions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
As the CI failure is expected, I'll go ahead and merge. |
Description
Daily automated diff review (2026-06-27) of the 14 commits merged to
developin the last 24 hours.Review scope:
dxmy,sxmy,glast-index-of-falsy(new packages), namespace TS declaration updates,ndarray/matrixdoc fixes, build-system guard additions, and miscellaneous housekeeping.Finding:
@stdlib/blas/ext/base/dxmyis missing themultiplicationandhadamardkeywords that the sibling@stdlib/blas/ext/base/sxmypackage includes. Both packages implement the same element-wise multiplication (Hadamard product) for different floating-point precisions (float64vsfloat32), so their keyword sets should be consistent.Changes in this PR:
lib/node_modules/@stdlib/blas/ext/base/dxmy/package.json: add"multiplication"and"hadamard"keywords between"multiply"and"transform"to matchsxmy/package.json.Related Issues
No.
Questions
No.
Other
Review results — all other areas clean:
dxmy/sxmyJS and C implementations: loop unrolling, stride/offset logic, return values — correctdxmy/sxmyREPL examples and// returnsannotations — math verified correctsxmyhas nofloat64/dxmycopy-paste leaksglast-index-of-falsyreversed-stride delegation togindexOfFalsyandN-1-idxindex conversion — correct; no "truthy" copy-paste leaksblas/ext/basenamespace TS declarations: alphabetical insertion, JSDoc descriptions, return types — correctndarray/matrixnamespace import ordering (Complex64beforeComplex128) — matches establishedndarray/vectorconventionnumber/uint64/ctorTSDoc fix (high word→low wordfor.lo) — correctmean/median/mode→mainvariable renames — correctValidation: style-guide compliance audit and bug scan across 14 commits; deliberately excluded subjective preferences and any concern requiring context outside the diff window.
Checklist
AI Assistance
Yes
No
Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding
Disclosure
This PR was authored end-to-end by Claude Code: the 14 commits merged to
developin the prior 24h were reviewed by four parallel subagents (two style auditors againstdocs/style-guidesand sibling reference packages, two bug hunters), findings cross-verified before applying any change. The single surviving fix — adding the missingmultiplicationandhadamardkeywords todxmy/package.jsonto match itssxmysibling — is metadata-only.@stdlib-js/reviewers