Skip to content

chore: update keywords - #13166

Merged
kgryte merged 2 commits into
developfrom
claude/fervent-archimedes-7hb8mg
Nov 10, 2026
Merged

kgryte merged 2 commits into
developfrom
claude/fervent-archimedes-7hb8mg

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Jun 27, 2026 •

Copy link
Copy Markdown
Member

Description

Daily automated diff review (2026-06-27) of the 14 commits merged to develop in the last 24 hours.

Review scope: dxmy, sxmy, glast-index-of-falsy (new packages), namespace TS declaration updates, ndarray/matrix doc fixes, build-system guard additions, and miscellaneous housekeeping.

Finding: @stdlib/blas/ext/base/dxmy is missing the multiplication and hadamard keywords that the sibling @stdlib/blas/ext/base/sxmy package includes. Both packages implement the same element-wise multiplication (Hadamard product) for different floating-point precisions (float64 vs float32), so their keyword sets should be consistent.

Changes in this PR:

  • lib/node_modules/@stdlib/blas/ext/base/dxmy/package.json: add "multiplication" and "hadamard" keywords between "multiply" and "transform" to match sxmy/package.json.

Related Issues

No.

Questions

No.

Other

Review results — all other areas clean:

  • dxmy/sxmy JS and C implementations: loop unrolling, stride/offset logic, return values — correct
  • dxmy/sxmy REPL examples and // returns annotations — math verified correct
  • sxmy has no float64/dxmy copy-paste leaks
  • glast-index-of-falsy reversed-stride delegation to gindexOfFalsy and N-1-idx index conversion — correct; no "truthy" copy-paste leaks
  • blas/ext/base namespace TS declarations: alphabetical insertion, JSDoc descriptions, return types — correct
  • ndarray/matrix namespace import ordering (Complex64 before Complex128) — matches established ndarray/vector convention
  • number/uint64/ctor TSDoc fix (high word → low word for .lo) — correct
  • Bernoulli mean/median/mode → main variable renames — correct
  • Makefile C-guard additions — correct

Validation: style-guide compliance audit and bug scan across 14 commits; deliberately excluded subjective preferences and any concern requiring context outside the diff window.

Checklist

AI Assistance

  • Yes

  • No

  • Code generation (e.g., when writing an implementation or fixing a bug)

  • Test/benchmark generation

  • Documentation (including examples)

  • Research and understanding

Disclosure

This PR was authored end-to-end by Claude Code: the 14 commits merged to develop in the prior 24h were reviewed by four parallel subagents (two style auditors against docs/style-guides and sibling reference packages, two bug hunters), findings cross-verified before applying any change. The single surviving fix — adding the missing multiplication and hadamard keywords to dxmy/package.json to match its sxmy sibling — is metadata-only.


@stdlib-js/reviewers

The `dxmy` package was missing the `multiplication` and `hadamard`
keywords that the sibling `sxmy` package includes. Both packages
implement the same element-wise multiplication (Hadamard product)
operation for different floating-point precisions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jun 27, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot

stdlib-bot commented Jun 27, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dxmy $\\color{green}405/405$
$\\color{green}+0.00\\%$
$\\color{green}26/26$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}405/405$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review November 10, 2026 03:55
@kgryte
kgryte requested a review from a team November 10, 2026 03:55
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 10, 2026
@kgryte kgryte changed the title fix: add missing keywords to dxmy package chore: update keywords Nov 10, 2026
@kgryte

kgryte commented Nov 10, 2026

Copy link
Copy Markdown
Member

As the CI failure is expected, I'll go ahead and merge.

@kgryte
kgryte merged commit 2d5e843 into develop Nov 10, 2026
24 of 27 checks passed
@kgryte
kgryte deleted the claude/fervent-archimedes-7hb8mg branch November 10, 2026 04:02
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants