Skip to content

Commit 66f3bbf

Browse files
committed
wifi: brcmfmac: cyw: Disable FWSUP with generic external SAE
Synaptics firmware for the SYN43436s and SYN43436P supports the in-firmware supplicant (FWSUP), so after an external SAE authentication the driver selects PSK offload, the supplicant skips the 4-way handshake, and the firmware doesn't perform it either. The AP then deauthenticates the station. Until now this has been avoided by disabling FWSUP with the feature_disable module parameter. Instead, clear the FWSUP feature when the generic (non-Infineon) external SAE support is in use, so that WPA3 works regardless of any module parameters. Assisted-by: Claude Signed-off-by: Phil Elwell <phil@raspberrypi.com>
1 parent 50b9068 commit 66f3bbf

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

  • drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw

‎drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,11 @@ static void brcmf_cyw_feat_attach(struct brcmf_if *ifp)
274274
drvr->ops->external_auth = brcmf_cyw_external_auth;
275275
} else {
276276
brcmf_dbg(INFO, "using generic external SAE support\n");
277+
/* This firmware doesn't perform the 4-way handshake after an
278+
* external SAE authentication, so the in-firmware supplicant
279+
* must not be used - leave it to the host.
280+
*/
281+
drvr->feat_flags &= ~BIT(BRCMF_FEAT_FWSUP);
277282
}
278283
}
279284

0 commit comments

Comments
 (0)